-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
requesting metrics with dois in REST
- Loading branch information
Showing
4 changed files
with
94 additions
and
1 deletion.
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
.../vcr_cassettes/dois/GET_/dois_all_with_metrics/when_the_record_exists/returns_the_Doi.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kjgarza the way you use the
meta
object is a bit unconventional. Themeta
object for queries should not deal with individual dois, but provide a summary count. And this summary count should be independent of pagination, so all dois in the query result.I suggest to refactor to show counts (citations, views and downloads) for all dois in the query result here (each as a single number). And to show the citations, views, and downloads for each doi in the response for each doi. Which is more intuitive and makes it easy to show these counts with each doi.