Merge pull request #670 from datacite/fix_transfer_check

Don't reindex on doi transfer if no db update
datacite · Nov 5, 2020 · 4200d78 · 4200d78
2 parents bf5a500 + 3eb2b1d
commit 4200d78
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/app/jobs/transfer_job.rb b/app/jobs/transfer_job.rb
@@ -10,9 +10,13 @@ def perform(doi_id, options={})
     doi = Doi.where(doi: doi_id).first
 
     if doi.present? && options[:client_target_id].present?
-      doi.update_attributes(datacentre: options[:client_target_id])
+      # Success starts as true because update_attributes only returns false on error.
+      success = true
+      success = doi.update_attributes(datacentre: options[:client_target_id])
 
-      doi.__elasticsearch__.index_document
+      if success
+        self.__elasticsearch__.index_document
+      end
 
       Rails.logger.info "[Transfer] Transferred DOI #{doi.doi}."
     elsif doi.present?