don't set name_type to personal. datacite/bracco#400

datacite · Apr 17, 2020 · 741493e · 741493e
1 parent 9302127
commit 741493e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -60,7 +60,7 @@ GEM
     audited (4.9.0)
       activerecord (>= 4.2, < 6.1)
     aws-eventstream (1.1.0)
-    aws-partitions (1.297.0)
+    aws-partitions (1.298.0)
     aws-sdk-core (3.94.0)
       aws-eventstream (~> 1, >= 1.0.2)
       aws-partitions (~> 1, >= 1.239.0)
@@ -76,7 +76,7 @@ GEM
     aws-sdk-sqs (1.24.0)
       aws-sdk-core (~> 3, >= 3.71.0)
       aws-sigv4 (~> 1.1)
-    aws-sigv4 (1.1.1)
+    aws-sigv4 (1.1.2)
       aws-eventstream (~> 1.0, >= 1.0.2)
     base32-url (0.5)
     batch-loader (1.4.1)
@@ -102,7 +102,7 @@ GEM
       latex-decode (~> 0.0)
     binding_of_caller (0.8.0)
       debug_inspector (>= 0.0.1)
-    bolognese (1.5.15)
+    bolognese (1.5.16)
       activesupport (>= 4.2.5)
       benchmark_methods (~> 0.7)
       bibtex-ruby (>= 5.1.0)
@@ -133,7 +133,7 @@ GEM
     bullet (6.1.0)
       activesupport (>= 3.0.0)
       uniform_notifier (~> 1.11)
-    byebug (11.1.1)
+    byebug (11.1.2)
     cancancan (2.3.0)
     capybara (3.32.1)
       addressable

diff --git a/spec/concerns/crosscitable_spec.rb b/spec/concerns/crosscitable_spec.rb
@@ -151,8 +151,7 @@
       expect(meta["creators"]).to eq([{"familyName"=>"Fenner", "givenName"=>"Martin","name"=>"Fenner, Martin",
         "nameIdentifiers"=>
           [{"nameIdentifier"=>"https://orcid.org/0000-0003-1419-2405",
-            "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}],
-        "nameType"=>"Personal"}])
+            "nameIdentifierScheme"=>"ORCID", "schemeUri"=>"https://orcid.org"}]}])
       expect(meta["titles"]).to eq([{"title"=>"Eating your own Dog Food"}])
       expect(meta["publication_year"]).to eq("2016")
       expect(meta["publisher"]).to eq("DataCite")

diff --git a/spec/requests/dois_spec.rb b/spec/requests/dois_spec.rb
@@ -1411,8 +1411,7 @@
           "nameIdentifiers"=>
             [{"nameIdentifier"=>"https://orcid.org/0000-0003-1419-2405",
               "nameIdentifierScheme"=>"ORCID",
-              "schemeUri"=>"https://orcid.org"}],
-          "nameType"=>"Personal"}])
+              "schemeUri"=>"https://orcid.org"}]}])
         expect(json.dig('data', 'attributes', 'schemaVersion')).to eq("http://datacite.org/schema/kernel-4")
         expect(json.dig('data', 'attributes', 'source')).to eq("test")
         expect(json.dig('data', 'attributes', 'types')).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceType"=>"BlogPosting", "resourceTypeGeneral"=>"Text", "ris"=>"RPRT", "schemaOrg"=>"ScholarlyArticle")
@@ -1501,8 +1500,7 @@
           "nameIdentifiers"=>
             [{"nameIdentifier"=>"https://orcid.org/0000-0003-1419-2405",
               "nameIdentifierScheme"=>"ORCID",
-              "schemeUri"=>"https://orcid.org"}],
-          "nameType"=>"Personal"}])
+              "schemeUri"=>"https://orcid.org"}]}])
         expect(json.dig('data', 'attributes', 'schemaVersion')).to eq("http://datacite.org/schema/kernel-4")
         expect(json.dig('data', 'attributes', 'source')).to eq("test")
         expect(json.dig('data', 'attributes', 'types')).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceType"=>"BlogPosting", "resourceTypeGeneral"=>"Text", "ris"=>"RPRT", "schemaOrg"=>"ScholarlyArticle")