update graphql orcid support. #255

datacite · May 8, 2019 · 751c96b · 751c96b
1 parent 6423eaa
commit 751c96b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/app/models/researcher.rb b/app/models/researcher.rb
@@ -15,9 +15,9 @@ def self.find_by_id(id)
   def self.parse_message(id: nil, message: nil)
     {
       id: id,
-      given_name: message.dig("name", "given-names", "value"),
-      family_name: message.dig("name", "family-name", "value"),
-      name: message.dig("name", "credit-name", "value") }.compact
+      name: message.dig("name", "credit-name", "value"),
+      "givenName" => message.dig("name", "given-names", "value"),
+      "familyName" => message.dig("name", "family-name", "value") }.compact
   end
 
   def self.orcid_from_url(url)

diff --git a/spec/fixtures/vcr_cassettes/Researcher/find_by_id/found.yml b/spec/fixtures/vcr_cassettes/Researcher/find_by_id/found.yml
diff --git a/spec/fixtures/vcr_cassettes/Researcher/find_by_id/not_found.yml b/spec/fixtures/vcr_cassettes/Researcher/find_by_id/not_found.yml
diff --git a/spec/models/researcher_spec.rb b/spec/models/researcher_spec.rb
@@ -6,7 +6,7 @@
       id = "https://orcid.org/0000-0003-1419-2405"
       researchers = Researcher.find_by_id(id)
       expect(researchers.size).to eq(1)
-      expect(researchers.first).to eq(id: "https://orcid.org/0000-0003-1419-2405", name: "Martin Fenner", given_name: "Martin", family_name: "Fenner")
+      expect(researchers.first).to eq(id: "https://orcid.org/0000-0003-1419-2405", name: "Martin Fenner", "givenName" => "Martin", "familyName" => "Fenner")
     end
 
     it "not found" do