Merge pull request #911 from datacite/doi-enrichment-patch2

Rework subject serialization in for repositoris
datacite · Jan 24, 2023 · 7d1f547 · 7d1f547
2 parents fc6e5a7 + a04337f
commit 7d1f547
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/app/serializers/repository_serializer.rb b/app/serializers/repository_serializer.rb
@@ -97,9 +97,7 @@ class RepositorySerializer
     end
   end
 
-  attribute :subjects,
-
-    Proc.new { |object, params| } do |object|
+  attribute :subjects do |object|
       if object.subjects?
         Array.wrap(object.subjects).map { |subject|
           subject.transform_keys! do |key|

diff --git a/spec/requests/repositories_spec.rb b/spec/requests/repositories_spec.rb
@@ -387,6 +387,17 @@
         }
       end
 
+      let(:empty_subject_attributes) do
+        {
+          "data" => {
+            "type" => "repositories",
+            "attributes" => {
+              "subjects" => nil,
+            },
+          },
+        }
+      end
+
       it "updates the repository" do
         put "/repositories/#{client.symbol}", update_attributes, headers
         expect(json.dig("data", "attributes", "subjects")).to eq([
@@ -398,6 +409,11 @@
           }
         ])
       end
+
+      it "accepts an empty array" do
+        put "/repositories/#{client.symbol}", empty_subject_attributes, headers
+        expect(json.dig("data", "attributes", "subjects")).to match_array([])
+      end
     end