handle missing consortium_id #433

datacite · Feb 24, 2020 · a9a7fb9 · a9a7fb9
1 parent 1c6a4d5
commit a9a7fb9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/models/ability.rb b/app/models/ability.rb
@@ -26,10 +26,10 @@ def initialize(user)
       end
       can [:read], Provider
       can [:manage], ProviderPrefix do |provider_prefix|
-        provider_prefix.provider.consortium_id == user.consortium_id.upcase
+        provider_prefix.provider && provider_prefix.provider.consortium_id == user.consortium_id.upcase
       end
       can [:manage], Client do |client|
-        client.provider.consortium_id == user.consortium_id.upcase
+        client.provider && client.provider.consortium_id == user.consortium_id.upcase
       end
       can [:manage], ClientPrefix #, :client_id => user.provider_id
 
@@ -46,7 +46,7 @@ def initialize(user)
       can [:read], User
       can [:read], Phrase
       can [:read], Activity do |activity|
-        activity.doi.findable? || activity.doi.provider.consortium_id == user.consortium_id.upcase
+        activity.doi.findable? || activity.doi.provider && activity.doi.provider.consortium_id == user.consortium_id.upcase
       end
     elsif user.role_id == "provider_admin" && user.provider_id.present?
       can [:update, :read, :read_billing_information], Provider, symbol: user.provider_id.upcase