fix permissions for domains attribute. #687

datacite · Dec 15, 2020 · b1f72db · b1f72db
1 parent 4b4d81c
commit b1f72db
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/app/serializers/client_serializer.rb b/app/serializers/client_serializer.rb
@@ -48,6 +48,19 @@ class ClientSerializer
     object.password.present?
   end
 
+  attribute :domains,
+            if:
+              Proc.new { |object, params|
+                params[:current_ability] &&
+                  params[:current_ability].can?(
+                    :read_contact_information,
+                    object,
+                  ) ==
+                    true
+              } do |object|
+    object.domains
+  end
+
   attribute :contact_email,
             if:
               Proc.new { |object, params|

diff --git a/app/serializers/repository_serializer.rb b/app/serializers/repository_serializer.rb
@@ -43,6 +43,19 @@ class RepositorySerializer
     object.is_active.getbyte(0) == 1
   end
 
+  attribute :domains,
+            if:
+              Proc.new { |object, params|
+                params[:current_ability] &&
+                  params[:current_ability].can?(
+                    :read_contact_information,
+                    object,
+                  ) ==
+                    true
+              } do |object|
+    object.domains
+  end
+
   attribute :has_password,
             if:
               Proc.new { |object, params|

diff --git a/spec/requests/clients_spec.rb b/spec/requests/clients_spec.rb
@@ -297,7 +297,7 @@
 
       before do
         ProviderPrefix.import
-        sleep 2
+        sleep 3
       end
 
       it "updates the record" do
@@ -332,7 +332,6 @@
         ).to eq(client.symbol.downcase)
 
         get "provider-prefixes?query=#{prefix.uid}"
-        puts json
         expect(
           json.dig("meta", "total"),
         ).to eq(1)