Merge pull request #528 from datacite/contact-export

Allow export of multiple contacts with same email but different provider id

app/controllers/export_controller.rb

@@ -51,23 +51,25 @@ def contacts
       csv = headers.to_csv
 
       # Use a hashmap for the contacts to avoid duplicated
-      contacts = Hash.new
+      contacts = {}
 
       add_contact = Proc.new { |contacts, email, id, firstname, lastname, type|
         if email
-          unless contacts.has_key?(email)
-            contacts[email] = {
+          fabrica_id = id + "-" + email
+          unless contacts.has_key?(fabrica_id)
+            contacts[fabrica_id] = {
               'fabricaAccountId' => id,
-              'fabricaId' => id + "-" + email,
+              'fabricaId' => fabrica_id,
+              'email' => email,
               'firstName' => firstname,
               'lastName' => lastname.present? ? lastname : email,
             }
           end
 
-          if contacts[email].has_key?('type')
-            contacts[email]['type'] += ";" + type
+          if contacts[fabrica_id].has_key?('type')
+            contacts[fabrica_id]['type'] += ";" + type
           else
-            contacts[email]['type'] = type
+            contacts[fabrica_id]['type'] = type
           end
         end
       }
@@ -90,11 +92,11 @@ def contacts
         end
       end
 
-      contacts.each do |email, contact|
+      contacts.each do |_, contact|
         csv += CSV.generate_line [
           contact['fabricaAccountId'],
           contact['fabricaId'],
-          email,
+          contact['email'],
           contact['firstName'],
           contact['lastName'],
           contact['type'],

spec/requests/exports_spec.rb

@@ -82,45 +82,55 @@
 
       expect(last_response.status).to eq(200)
       csv = last_response.body.lines
-      expect(csv.length).to eq(5)
+      expect(csv.length).to eq(9)
       expect(csv[0]).to eq("fabricaAccountId,fabricaId,email,firstName,lastName,type\n")
       expect(csv[1]).to start_with("VIVA,[email protected],[email protected],Kristian,Garza,technical;secondaryTechnical")
       expect(csv[2]).to start_with("VIVA,[email protected],[email protected],Martin,Fenner,service;secondaryService")
       expect(csv[3]).to start_with("VIVA,[email protected],[email protected],Robin,Dasler,voting")
       expect(csv[4]).to start_with("VIVA,[email protected],[email protected],Trisha,Cruse,billing;secondaryBilling")
+      expect(csv[5]).to start_with("UVA,[email protected],[email protected],Kristian,Garza,technical;secondaryTechnical")
+      expect(csv[6]).to start_with("UVA,[email protected],[email protected],Martin,Fenner,service;secondaryService")
+      expect(csv[7]).to start_with("UVA,[email protected],[email protected],Robin,Dasler,voting")
+      expect(csv[8]).to start_with("UVA,[email protected],[email protected],Trisha,Cruse,billing;secondaryBilling")
     end
 
     it 'returns all contacts from date', vcr: false do
       get "/export/contacts?from-date=#{Date.today}", nil, admin_headers
 
       expect(last_response.status).to eq(200)
       csv = last_response.body.lines
-      expect(csv.length).to eq(5)
+      expect(csv.length).to eq(9)
       expect(csv[0]).to eq("fabricaAccountId,fabricaId,email,firstName,lastName,type\n")
       expect(csv[1]).to start_with("VIVA,[email protected],[email protected],Kristian,Garza,technical;secondaryTechnical")
       expect(csv[2]).to start_with("VIVA,[email protected],[email protected],Martin,Fenner,service;secondaryService")
       expect(csv[3]).to start_with("VIVA,[email protected],[email protected],Robin,Dasler,voting")
       expect(csv[4]).to start_with("VIVA,[email protected],[email protected],Trisha,Cruse,billing;secondaryBilling")
+      expect(csv[5]).to start_with("UVA,[email protected],[email protected],Kristian,Garza,technical;secondaryTechnical")
+      expect(csv[6]).to start_with("UVA,[email protected],[email protected],Martin,Fenner,service;secondaryService")
+      expect(csv[7]).to start_with("UVA,[email protected],[email protected],Robin,Dasler,voting")
+      expect(csv[8]).to start_with("UVA,[email protected],[email protected],Trisha,Cruse,billing;secondaryBilling")
     end
 
     it 'returns voting contacts', vcr: false do
       get "/export/contacts?type=voting", nil, admin_headers
 
       expect(last_response.status).to eq(200)
       csv = last_response.body.lines
-      expect(csv.length).to eq(2)
+      expect(csv.length).to eq(3)
       expect(csv[0]).to eq("fabricaAccountId,fabricaId,email,firstName,lastName,type\n")
       expect(csv[1]).to start_with("VIVA,[email protected],[email protected],Robin,Dasler,voting")
+      expect(csv[2]).to start_with("UVA,[email protected],[email protected],Robin,Dasler,voting")
     end
 
     it 'returns billing contacts', vcr: false do
       get "/export/contacts?type=billing", nil, admin_headers
 
       expect(last_response.status).to eq(200)
       csv = last_response.body.lines
-      expect(csv.length).to eq(2)
+      expect(csv.length).to eq(3)
       expect(csv[0]).to eq("fabricaAccountId,fabricaId,email,firstName,lastName,type\n")
       expect(csv[1]).to start_with("VIVA,[email protected],[email protected],Trisha,Cruse,billing;secondaryBilling")
+      expect(csv[2]).to start_with("UVA,[email protected],[email protected],Trisha,Cruse,billing;secondaryBilling")
     end
   end
 end