rubocop suggestions

datacite · Dec 18, 2019 · d03aa60 · d03aa60
1 parent 2c29dee
commit d03aa60
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -65,7 +65,7 @@ def authenticate_user_with_basic_auth!
 
   def authenticate_user!
     type, credentials = type_and_credentials_from_request_headers
-    return false unless credentials.present?
+    return false if credentials.blank?
 
     @current_user = User.new(credentials, type: type)
   end

diff --git a/app/controllers/clients_controller.rb b/app/controllers/clients_controller.rb
@@ -121,7 +121,7 @@ def create
   end
 
   def update
-    if @client.update_attributes(safe_params)
+    if @client.update(safe_params)
       options = {}
       options[:meta] = { dois: doi_count(client_id: params[:id]) }
       options[:is_collection] = false
@@ -142,7 +142,7 @@ def destroy
       status = 400
       logger.warn message
       render json: { errors: [{ status: status.to_s, title: message }] }.to_json, status: status
-    elsif @client.update_attributes(is_active: nil, deleted_at: Time.zone.now)
+    elsif @client.update(is_active: nil, deleted_at: Time.zone.now)
       @client.send_delete_email unless Rails.env.test?
       head :no_content
     else