fix bool handling in facets

datacite · Apr 16, 2021 · d4d91b4 · d4d91b4
1 parent 3fa19e6
commit d4d91b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/controllers/concerns/facetable.rb b/app/controllers/concerns/facetable.rb
@@ -154,11 +154,11 @@ def facet_by_key(arr)
     end
 
     def facet_by_bool(arr)
-      values = { 0 => "no", 1 => "yes" }
+      id = hsh["key"] == 1 ? "true" : "false"
       arr.map do |hsh|
         {
-          "id" => hsh["key"],
-          "title" => values[hsh["key"]],
+          "id" => id,
+          "title" => id.capitalize,
           "count" => hsh["doc_count"],
         }
       end

diff --git a/app/graphql/types/base_connection.rb b/app/graphql/types/base_connection.rb
@@ -90,11 +90,11 @@ def facet_by_key(arr)
   end
 
   def facet_by_bool(arr)
-    values = { 0 => "no", 1 => "yes" }
+    id = hsh["key"] == 1 ? "true" : "false"
     arr.map do |hsh|
       {
-        "id" => hsh["key"],
-        "title" => values[hsh["key"]],
+        "id" => id,
+        "title" => id.capitalize,
         "count" => hsh["doc_count"],
       }
     end