handle orcid api errors gracefully

app/models/person.rb

@@ -8,6 +8,12 @@ def self.find_by_id(id)
 
     url = "https://pub.orcid.org/v3.0/#{orcid}/person"
     response = Maremma.get(url, accept: "json")
+
+    if response.status >= 405
+      message = response.body.dig("errors", 0, "title", "developer-message") || "Something went wrong in ORCID"
+      fail ::Faraday::ClientError, message
+    end 
+
     return {} if response.status != 200
 
     message = response.body.dig("data")
@@ -58,6 +64,10 @@ def self.query(query, options={})
     url = "https://pub.orcid.org/v3.0/expanded-search/?" + URI.encode_www_form(params)
 
     response = Maremma.get(url, accept: "json")
+    if response.status >= 400
+      message = response.body.dig("errors", 0, "title", "developer-message") || "Something went wrong in ORCID"
+      fail ::Faraday::ClientError, message
+    end 
 
     return [] if response.status != 200
 

spec/graphql/types/person_type_spec.rb

@@ -221,4 +221,40 @@
       expect(person.fetch("alternateName")).to eq(["Nélida R. Villaseñor"])
     end
   end
+
+  describe "query people with error", elasticsearch: true, vcr: true do
+    let(:query) do
+      %(query {
+        people(query: "container.identifier:2658-719X") {
+          totalCount
+          pageInfo {
+            endCursor
+            hasNextPage
+          }
+          nodes {
+            id
+            name
+            givenName
+            familyName
+            alternateName
+            works {
+              totalCount
+              published {
+                id
+                title
+                count
+              }
+            }
+          }
+        }
+      })
+    end
+
+    it "returns error" do
+      response = LupoSchema.execute(query).as_json
+
+      expect(response.dig("data")).to be_nil
+      expect(response.dig("errors", 0, "message")).to eq("org.apache.solr.client.solrj.impl.HttpSolrClient.RemoteSolrException Full validation error: Error from server at http://solr-loc.orcid.org/solr/profile: undefined field container.identifier")
+    end
+  end
 end

spec/models/person_spec.rb

@@ -138,5 +138,10 @@
       expect(person.identifiers).to be_empty
       expect(person.country).to be_nil
     end
+
+    it "handle errors gracefully" do
+      query = "container.identifier:2658-719X"
+      expect { Person.query(query) }.to raise_error(Faraday::ClientError, /Error from server/)
+    end
   end
 end