Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subjects valueUri to be null #1044

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

richardhallett
Copy link
Contributor

Allow json schema validation to accept null values for valueUri

Purpose

Fix for datacite/datacite#1971

Approach

Ensure null can be an accepted validation type for json schema.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Allow json schema validation to accept null
@richardhallett richardhallett merged commit 3c80ee2 into master Nov 20, 2023
12 checks passed
@richardhallett richardhallett deleted the allow_valueUri_null branch November 20, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants