Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove required properties in OpenAPI yaml DoiPropertiesMetadata schema to improve behavior in API reference #1046

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Remove required properties in OpenAPI yaml DoiPropertiesMetadata schema to improve behavior in API reference #1046

merged 2 commits into from
Nov 27, 2023

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Nov 22, 2023 •
edited
Loading

Fixes #1045

Purpose

Removes required properties in OpenAPI yaml DoiPropertiesMetadata schema to improve behavior in API reference at support.datacite.org.

closes: #1045

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

KellyStathis
KellyStathis approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@KellyStathis KellyStathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@codycooperross codycooperross merged commit 78f867e into master Nov 27, 2023
12 checks passed
@codycooperross codycooperross deleted the codycooperross/issue1045 branch November 27, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyStathis KellyStathis KellyStathis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove required properties in OpenAPI yaml to improve behavior in API reference
2 participants
@codycooperross @KellyStathis