Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema 4.5 - OpenAPI yaml updates #1048

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Schema 4.5 - OpenAPI yaml updates #1048

merged 3 commits into from
Jan 22, 2024

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Dec 1, 2023

Purpose

Updates OpenAPI yaml with new Schema 4.5 values.

closes: datacite/datacite#1975

Approach

Open Questions and Pre-Merge TODOs

  • Should not be merged until the release of Schema 4.5.

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross changed the base branch from master to schema-4.5-r3 December 1, 2023 21:30
@codycooperross codycooperross changed the title Metadata 4.5 - OpenAPI yaml updates Schema 4.5 - OpenAPI yaml updates Dec 1, 2023
Base automatically changed from schema-4.5-r3 to master December 14, 2023 17:13
Copy link
Collaborator

@KellyStathis KellyStathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Only one thing I noticed, I think resource-type-id needs new values for instrument and study-registration here:

name: resource-type-id

@codycooperross
Copy link
Contributor Author

resource-type-id

Good catch—fixed!

@codycooperross codycooperross merged commit 2e7df0d into master Jan 22, 2024
13 checks passed
@codycooperross codycooperross deleted the schema-4.5-openapi branch January 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata 4.5 - OpenAPI yaml updates for 4.5 values
2 participants