Allow events to trigger on specific conditions

[ashwinisukale]

Purpose

Events not created when DOI first created in registered or draft state

closes: datacite/datacite#1710

Approach

Events should be created at following conditions,

• When we create a DOI directly with findable state
• When state is findable and there is an update in any of these fields related_identifiers, creators, funding_references
• When we change DOI state from any other state to findable

Open Questions and Pre-Merge TODOs

Learning

Types of changes

• Bug fix (non-breaking change which fixes an issue)

• New feature (non-breaking change which adds functionality)

• Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[digitaldogsbody]

Great work Ashwini :)

[digitaldogsbody]

I really like this refactor away from an ever-increasing list of boolean clauses, very elegant!

[ashwinisukale]

Thank you @digitaldogsbody :)

Also saved_change_to_attribute? this method only execute when we have update call, so we never captured the create DOI call before because of this method checks.

We missed the events for the DOI which are created directly with findable state.

[ashwinisukale]

saved_changes will work for both create and update action.