Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard agains incomplete related_dois #1069

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Dec 11, 2023

Purpose

Some related_identifiers do not have all the required fields in the database due to changes inthe schema.

closes: #1066, #1067, #1068

Approach

Make sure all related_identifiers is a hash and has all the required fields

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
Copy link
Contributor Author

jrhoads commented Dec 11, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jrhoads jrhoads requested review from svogt0511, digitaldogsbody and a team December 11, 2023 18:46
@jrhoads jrhoads merged commit 4df4d77 into master Dec 11, 2023
12 of 23 checks passed
@jrhoads jrhoads deleted the 12-11-Guard_against_incimplete_related_dois branch December 11, 2023 20:10
@jrhoads
Copy link
Contributor Author

jrhoads commented Dec 11, 2023

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `underscore' for nil:NilClass
2 participants