Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new publisher object in graphql #1075

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

bklaing2
Copy link
Member

@bklaing2 bklaing2 commented Dec 18, 2023

Purpose

Adds support for the new publisher objected to GraphQL. When querying a work, publisher is now queried as

publisher {
  name
  publisherIdentifier
  publisherIdentifierScheme
  schemeUri
  lang
}

closes: datacite/akita#310 #1013

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 force-pushed the metadata-4.5-graphql-publisher-support branch from d1f8e19 to 3083f3d Compare December 19, 2023 09:04
@bklaing2 bklaing2 force-pushed the metadata-4.5-graphql-publisher-support branch from 70d0009 to db4a8c1 Compare January 9, 2024 13:50
@codycooperross codycooperross self-requested a review February 27, 2024 20:52
@svogt0511 svogt0511 merged commit 4dc7819 into master Feb 27, 2024
13 checks passed
@svogt0511 svogt0511 deleted the metadata-4.5-graphql-publisher-support branch February 27, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata 4.5 - Expanded support for new publisher values in GraphQL API/Akita
3 participants