Added log to verify that method is getting called at right condition #1081
Conversation
There was a problem hiding this comment.
@ashwinisukale Looks good. Is there not a way to simulate this locally without logging in prod?
| send_import_message(to_jsonapi) if relevant_changes.any? | ||
| if relevant_changes.any? | ||
| send_import_message(to_jsonapi) | ||
| Rails.logger.info "[Event Data Import Message] #{aasm_state} #{to_jsonapi.inspect} send to Event Data service." |
There was a problem hiding this comment.
This will potentially create a lot of log entries in production for every update that is triggering a import.
You could also get this on the other side during the actual import, i.e. levriero.
I think this is fine if you really need this information to debug in production, but if you can check how many logs are being added that'd be good, and if it's a lot (discuss on slack) then we might want to remove it at some point. Log collection does have an associated cost as well as being extra data to parse.
There was a problem hiding this comment.
Yes @richardhallett I will not be pushing this to production. I just want to test this on staging. I will be removing this log once testing is done. Sorry I did not mentioned this in the description
|
@kaysiz locally its not possible to test this integration testing at local where lupo is putting a message on a queue and levriero is reading that message off the queue |
Purpose
Added logs to investigate the issue.
closes: datacite/datacite#1710
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: