Remove unwanted test logs #1085
Conversation
| if relevant_changes.any? || (created == updated) | ||
| send_import_message(to_jsonapi) | ||
| Rails.logger.info "[Event Data Import Message] send to Event Data service. #{aasm_state} #{to_jsonapi} " | ||
| Rails.logger.info "[Event Data Import Message] State: #{aasm_state} Params: #{to_jsonapi} message sent to Event Data service." |
There was a problem hiding this comment.
@richardhallett I feel we should have this log which confirms that we did send a message from Lupo to Sqs. Right now there is no way to verify if Lupo sent a message correctly to sqs or not.
I would love to hear your thoughts on this, as I am adding some logs which might increase storage cost.
There was a problem hiding this comment.
Something that might help if I understand this correctly. The AWS::SQS::Client.send_message does return a result -> https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/SQS/Client.html#send_message-instance_method.
So you could get the result (https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/SQS/Types/SendMessageResult.html) by simply saving the value returned by send_import_message.
result = send_import_message(to_jsonapi)
…r created and updated datetime
Purpose
Log a message when we send a message from Lupo to SQS.
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: