Align OtherDoi bulk indexing with DataciteDoi bulk indexing. #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jrhoads
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes changes to the
other_doi.rbfile that aim to refactor and improve the 'import_in_bulk' method.What changed?
The
import_in_bulkmethod within theother_doi.rbfile is now broken down into smaller responsibilities. In the updated method, database records are retrieved from an array of database ids, which are subsequently uploaded to Elasticsearch in batches. This approach aids in preventing the creation of bulk requests to Elasticsearch that are too large. Moreover, error handling and logging have been enhanced.How to test?
These changes can be tested by running the
import_in_bulkmethod with a large amount of database ids. It should handle the request smoothly, without any bulk request size issues.Why make this change?
These changes enhance scalability by accommodating larger amounts of database ids for Elasticsearch indexing. Also, they improve the overall readability and maintainability of the codebase.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: