Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return dois from other registration agencies through REST API (optionally) #1202

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Jun 29, 2024

Purpose

There are many dois in the database and elasticsearch that are not originally registered by datacite.
These are unavailable through the current REST API. They are available through the GraphQL api.
We would like to make these available as read-only through the REST api.

Approach

Add an optional parameter that enables the inclusion of dois from other registration agencies.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads requested a review from a team June 29, 2024 20:09
Copy link
Contributor

@richardhallett richardhallett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on conversations internally, this is a reasonable compromise to allow searching using REST API over non DataCite DOIs without having to create more complicated new endpoints.
Long term this probably needs to be reworked to consider how search happens for our API endpoints when also mixed in with registration services.

@jrhoads jrhoads merged commit 226f15d into master Jul 1, 2024
26 checks passed
@jrhoads jrhoads deleted the rest-add-other-option branch July 1, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants