-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up openapi.yaml #1236
Merged
Merged
Clean up openapi.yaml #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… major properties
…is" or "prefix"; "prefix" and "suffix" is equivalent to "prefix" only)
10 tasks
…_openapi_updates
I added fixes for a typo or two. This looks great! The inline schema documentation is really helpful. I skimmed the mentioned endpoint documentation. |
codycooperross
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make our OpenAPI specification more accurate, with particular attention to response structures.
closes: #1230
Approach
Change summary
"meta"
, specify which properties are available within the "meta" object.Activity
,Client
,ClientPrefix
,Event
,Prefix
,Provider
,ProviderPrefix
, andReport
objects to reflect their contents.DoiListItem
andDoiDetailItem
. This was formerly done for the attributes within the item, viaDoisAttributes
(for the attributes in the list response) andDoiAttribute
(for the attributes in the (detailed)singleton response).Open Questions and Pre-Merge TODOs
For the reviewer, I'd appreciate a quick check on the following endpoints' documentation. These are among the most important for our users, and where I made the most changes to the spec in this PR. These links are a preview of the changes from this branch:
POST /dois
: https://support.datacite.org/reference/post_dois-1PUT /dois{id}
: https://support.datacite.org/reference/put_dois-id-1GET /clients{id}
: https://support.datacite.org/reference/get_clients-id-1 response structureGET /providers{id}
:https://support.datacite.org/reference/get_providers-id-1 response structurePost-merge tasks for @KellyStathis :
Learning
ideas for future work: #1235
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: