Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor large spec (spec/requests/datacite_dois_spec.rb) #1251

Merged
merged 10 commits into from
Sep 27, 2024

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Sep 24, 2024

Purpose

Breaks the ~5k spec into smaller focused specs.
Two results

  1. Greater granularity when an area needs to change
  2. Spread specs out when run in a parallel ci setting.

Related to #1248

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads requested a review from a team September 26, 2024 15:49
@jrhoads jrhoads merged commit 0d319c7 into master Sep 27, 2024
13 checks passed
@jrhoads jrhoads deleted the refactor-large-spec branch September 27, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants