Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema 4.6 #1259

Merged
merged 12 commits into from
Nov 20, 2024
Merged

Schema 4.6 #1259

merged 12 commits into from
Nov 20, 2024

Conversation

kaysiz
Copy link
Contributor

@kaysiz kaysiz commented Oct 8, 2024 •
edited by codycooperross
Loading

Purpose

closes: #1269

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@ashwinisukale ashwinisukale requested review from codycooperross and a team October 24, 2024 06:30
@ashwinisukale ashwinisukale marked this pull request as ready for review October 24, 2024 06:30
jrhoads
jrhoads reviewed Oct 24, 2024
View reviewed changes
.ruby-version Show resolved Hide resolved
ashwinisukale
ashwinisukale approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ashwinisukale ashwinisukale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@kaysiz kaysiz merged commit 53103ab into master Nov 20, 2024
38 checks passed
@kaysiz kaysiz deleted the schema-4.6 branch November 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhoads jrhoads jrhoads approved these changes

@ashwinisukale ashwinisukale ashwinisukale approved these changes

@codycooperross codycooperross Awaiting requested review from codycooperross

Assignees

@ashwinisukale ashwinisukale

@kaysiz kaysiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorporate schema 4.6 changes
3 participants
@kaysiz @ashwinisukale @jrhoads