Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add middleware error handling #1275

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Nov 15, 2024

Purpose

closes: #1274

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team November 18, 2024 06:48
@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Nov 18, 2024
@wendelfabianchinsamy wendelfabianchinsamy merged commit 586a037 into master Nov 18, 2024
19 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the add-middleware-error-handling branch November 18, 2024 12:20
Copy link

sentry-io bot commented Nov 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: no implicit conversion of String into Integer DataciteDoisController#show View Issue
  • ‼️ Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":{"root_cause":[{"type":"parse_exception","reason":"parse_exception: Encountered "... ActivitiesController#index View Issue
  • ‼️ Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"failed to parse sett... ActivitiesController#index View Issue
  • ‼️ ActionController::Redirecting::UnsafeRedirectError: Unsafe redirect to "https://publications.rwth-aachen.de/record/995912", pass allow_other_host: tr... IndexController#show View Issue
  • ‼️ JSONAPI::Serializer::UnsupportedIncludeError: JSONAPI::Serializer::UnsupportedIncludeError ClientsController#index View Issue

Did you find this useful? React with a 👍 or 👎

@jrhoads
Copy link
Contributor

jrhoads commented Nov 19, 2024

In this case it is actually a good thing to receive Sentry errors as a result of the deployment. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add middleware error handling
2 participants