Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agency to dois response #1281

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Add agency to dois response #1281

merged 4 commits into from
Nov 20, 2024

Conversation

bklaing2
Copy link
Member

Purpose

Registration agency is returned in the graphQL response, but not the REST API

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bklaing2 bklaing2 requested a review from a team November 19, 2024 23:09
@bklaing2 bklaing2 merged commit fdf9ec8 into master Nov 20, 2024
19 checks passed
@bklaing2 bklaing2 deleted the add-agency-to-dois-response branch November 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants