Fix for XML not updating when blank or nil values are sent via JSON using REST API #1307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes: datacite/datacite#2264
Approach
The
read_attrs
method was only used in one place to detect when @params 1) contains no values exceptxml
or 2) contains values that might initiate XML regeneration, then using that condition to set theregenerate
parameter. This PR rewrites that method to detect any changes, including blank or nil values, anywhere in the metadata-related values of the @params aside fromschemaVersion
, which is set earlier in thecleanse
method and thus always has a value.Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: