Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alternateIdentifiers from XML when alternateIdentifiers parameter is blank or nil #1308

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Jan 13, 2025

Purpose

closes: datacite/datacite#1899

Approach

Adds safety to conversion from alternateIdentifiers param to identifiers param. Checks for the existence of alternateIdentifiers and identifiers param rather than checking if either is blank.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross requested a review from a team January 13, 2025 18:26
@codycooperross codycooperross merged commit 14d68b0 into master Jan 14, 2025
18 of 19 checks passed
@codycooperross codycooperross deleted the blank-alt-id-fix branch January 14, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to fully remove alternateIdentifiers via REST API
2 participants