Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install imagemagick in CI #1310

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Jan 15, 2025

Purpose

Paperclip-related problems in CI pointed to imagemagick not being installed.

Turns out that the new image for ubuntu-latest used in CI is now based on ubuntu-24.04, where it previously was based on ubuntu-22.04. They have different default packages installed. as outlined in
https://github.com/actions/runner-images/blob/ubuntu22/20250105.1/images/ubuntu/Ubuntu2204-Readme.md#installed-apt-packages
and https://github.com/actions/runner-images/blob/ubuntu24/20250105.1/images/ubuntu/Ubuntu2404-Readme.md#installed-apt-packages

In 22.04 imagemagick was already installed, whereas in 24.04 it is not installed by default.

Approach

Explicitly installs imgagemagick in CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads requested a review from a team January 15, 2025 10:21
@jrhoads jrhoads merged commit 59776af into master Jan 15, 2025
19 checks passed
@jrhoads jrhoads deleted the update-action-imagemagick branch January 15, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants