Replace the /sbin/setuser app bundle install line with the following … #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to properly run bundle install as the app user
ashwinisukale
requested review from
jrhoads,
lizkrznarich,
kaysiz,
wendelfabianchinsamy,
codycooperross and
digitaldogsbody
kaysiz
reviewed
Nov 15, 2024
| @@ -46,7 +46,7 @@ RUN mkdir -p /home/app/webapp/vendor/bundle && \ | |||
| WORKDIR /home/app/webapp | |||
| RUN gem install rubygems-update -v 3.5.6 && \ | |||
| gem install bundler:2.5.6 && \ | |||
| /sbin/setuser app bundle install --path vendor/bundle | |||
| su - app -c "bundle install --path vendor/bundle" | |||
There was a problem hiding this comment.
@ashwinisukale can you add the error you are getting with the old line.
There was a problem hiding this comment.
call_build_and_push / build
buildx failed with: ERROR: failed to solve: process "/bin/sh -c gem install rubygems-update -v 3.5.6 && gem install bundler:2.5.6 && /sbin/setuser app bundle install --path vendor/bundle" did not complete successfully: exit code: 5
kaysiz
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the /
sbin/setuserappbundle installline with the following to properly runbundle installas the app user:Purpose
error I was getting:
call_build_and_push / build
buildx failed with: ERROR: failed to solve: process "/bin/sh -c gem install rubygems-update -v 3.5.6 && gem install bundler:2.5.6 && /sbin/setuser app bundle install --path vendor/bundle" did not complete successfully: exit code: 5