Fix compressed exception lookup

Check all exceptions for code 69 not just the first This was breaking any report that sent other exceptions that were not the first.
datacite · Feb 7, 2024 · ea41f0a · ea41f0a
1 parent 9753159
commit ea41f0a
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/app/models/report.rb b/app/models/report.rb
@@ -115,9 +115,9 @@ def self.compressed_report?
     # check for data sets !empty
     return nil if exceptions.empty? || compressed.nil?
 
-    code = exceptions.first.fetch("code", "")
+    codes = exceptions.map { |exception| exception.fetch("code", "") }
 
-    (code == 69) && ((release.downcase == "rd1") || (release.downcase == "rd2"))
+    codes.include?(69) && ((release.downcase == "rd1") || (release.downcase == "rd2"))
   end
 
   def normal_report?
@@ -127,8 +127,9 @@ def normal_report?
 
   def compressed_report?
     return nil if self.exceptions.nil? || self.exceptions.empty?
-    code = self.exceptions.first.fetch("code", "")
-    (code == 69) && ((release.downcase == "rd1") || (release.downcase == "rd2"))
+    codes = exceptions.map { |exception| exception.fetch("code", "") }
+
+    codes.include?(69) && ((release.downcase == "rd1") || (release.downcase == "rd2"))
   end
 
   def resolution_report?