Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is imo a bit of a hack.
Ideally data should never get saved that needs cleaning. But this is the simplest solution without major refactoring
Purpose
The reason the exception throws is that attempting to do model changes when the validation is invalid.
closes: #161
Approach
By checking validation before attempting to clean data
Open Questions and Pre-Merge TODOs
N/A
Learning
I spent way too much time digging about with this trying to do it properly, which imo would involve us saving the data, this is probably also more true now as we no longer have "old" style reports which had no attachments, when this was first created it was attempted to handle both cases.
So now we should ideally refactor this all out and probably remove the database column as well.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: