feat(structures): Can not add identifier to a structure if a same typ…

…e and value already exist, see #115

src/api/structures/__tests__/identifiers.test.js

@@ -1,4 +1,7 @@
-import { structures as resource, identifiers as subresource } from '../../resources';
+import {
+  structures as resource,
+  identifiers as subresource,
+} from '../../resources';
 
 let authorization;
 let id;
@@ -77,6 +80,22 @@ describe('API > structures > identifiers > create', () => {
       .send(rest)
       .expect(400);
   });
+
+  it('should return 204 if an identifier with same type and same value already exists', async () => {
+    const paylod = { type: 'siret', value: '12345678912346' };
+
+    await global.superapp
+      .post(`/${resource}/${resourceId}/${subresource}`)
+      .set('Authorization', authorization)
+      .send(paylod)
+      .expect(201);
+
+    await global.superapp
+      .post(`/${resource}/${resourceId}/${subresource}`)
+      .set('Authorization', authorization)
+      .send(paylod)
+      .expect(204);
+  });
 });
 
 describe('API > structures > identifiers > update', () => {

src/api/structures/identifiers/identifiers.middlewares.js

@@ -0,0 +1,8 @@
+import { identifiersRepository } from '../../commons/repositories';
+
+export const validateStructureIdentifierCreatePayload = async (req, res, next) => {
+  const { type, value } = req.body;
+  const { resourceId } = req.params;
+  const check = await identifiersRepository.findOne({ resourceId, type, value });
+  return check ? res.status(204).json() : next();
+};

src/api/structures/identifiers/identifiers.routes.js

@@ -6,14 +6,16 @@ import { saveInElastic, saveInStore } from '../../commons/middlewares/event.midd
 import { readQuery, readQueryWithLookup } from '../../commons/queries/identifiers.query';
 import elasticQuery from '../../commons/queries/structures.elastic';
 import { identifiersRepository as repository, structuresRepository } from '../../commons/repositories';
-import { identifiers as subresource, structures as resource } from '../../resources';
+import { structures as resource, identifiers as subresource } from '../../resources';
+import { validateStructureIdentifierCreatePayload } from './identifiers.middlewares';
 
 const router = new express.Router();
 
 router.route(`/${resource}/:resourceId/${subresource}`)
   .get(controllers.list(repository, readQuery))
   .post([
     createContext,
+    validateStructureIdentifierCreatePayload,
     setGeneratedInternalIdInContext(subresource),
     controllers.create(repository, readQueryWithLookup),
     saveInStore(subresource),

src/openapi/paths/structures/identifiers.yml

@@ -57,6 +57,8 @@ collectionMethods:
           application/json:
             schema:
               $ref: '../../api.yml#/components/schemas/StructureIdentifier'
+      '204':
+        description: 'No content'
       '400':
         $ref: '../../api.yml#/components/responses/BadRequest'
       '401':