fix(mentions): Complete corrections

dataesr · Oct 31, 2024 · 8a35f35 · 8a35f35
1 parent e0a0613
commit 8a35f35
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 48 deletions.
diff --git a/client/src/pages/mentions.jsx b/client/src/pages/mentions.jsx
@@ -114,43 +114,11 @@ export default function Mentions() {
         return mention;
       }),
     );
-    const correctedMentions = mentions
-      .filter((correctedMention) => correctedMention.hasCorrection)
-      .map((correctedMention) => ({
-        id: correctedMention.id,
-        doi: correctedMention.doi,
-        texts: [
-          {
-            text: correctedMention.context,
-            class_attributes: {
-              classification: {
-                used: {
-                  previousValue: correctedMention.mention_context_original.used,
-                  score: 1.0,
-                  value: correctedMention.mention_context.used,
-                },
-                created: {
-                  previousValue:
-                    correctedMention.mention_context_original.created,
-                  score: 1.0,
-                  value: correctedMention.mention_context.created,
-                },
-                shared: {
-                  previousValue:
-                    correctedMention.mention_context_original.shared,
-                  score: 1.0,
-                  value: correctedMention.mention_context.shared,
-                },
-              },
-            },
-          },
-        ],
-      }));
-    setCorrections(correctedMentions);
-    setSelectedMentions([]);
+    setCorrections(getMentionsCorrections(mentions));
     setCorrectionsUsed(DEFAULT_CORRECTION);
     setCorrectionsCreated(DEFAULT_CORRECTION);
     setCorrectionsShared(DEFAULT_CORRECTION);
+    setSelectedMentions([]);
     switchCharacterizationsModal();
   };
   const feedback = async () => {
@@ -179,7 +147,7 @@ export default function Mentions() {
     }
   };
   const undo = (_mentions, _mention) => {
-    const mentionTmp = mentions.map((mention) => {
+    const mentionTmp = _mentions.map((mention) => {
       if (mention.id === _mention.id) {
         return {
           ...mention,
@@ -513,7 +481,10 @@ export default function Mentions() {
           </Button>
         </ModalContent>
         <ModalFooter>
-          <Button onClick={addCorrections} title="Validate modifications">
+          <Button
+            onClick={addCorrections}
+            title={`Validate modification${corrections.length > 1 ? 's' : ''}`}
+          >
             {`Validate modification${corrections.length > 1 ? 's' : ''}`}
           </Button>
         </ModalFooter>
@@ -560,8 +531,11 @@ export default function Mentions() {
           </Select>
         </ModalContent>
         <ModalFooter>
-          <Button onClick={switchType} title="Validate modifications">
-            Validate modifications
+          <Button
+            onClick={switchType}
+            title={`Validate modification${corrections.length > 1 ? 's' : ''}`}
+          >
+            {`Validate modification${corrections.length > 1 ? 's' : ''}`}
           </Button>
         </ModalFooter>
       </Modal>

diff --git a/client/src/utils/curations.jsx b/client/src/utils/curations.jsx
@@ -11,11 +11,55 @@ const getAffiliationsCorrections = (affiliations) => affiliations
 
 const getMentionsCorrections = (mentions) => mentions
   .filter((mention) => mention.hasCorrection)
-  .map((mention) => ({
-    id: mention.id,
-    doi: mention.doi,
-    type: mention.type,
-    previousType: mention.type_original,
-  }));
+  .map((mention) => {
+    const corrections = [];
+    if (mention.type !== mention.type_original) {
+      corrections.push({
+        id: mention.id,
+        doi: mention.doi,
+        type: mention.type,
+        previousType: mention.type_original,
+      });
+    }
+    if (
+      mention.mention_context.used
+          !== mention.mention_context_original.used
+        || mention.mention_context.created
+          !== mention.mention_context_original.created
+        || mention.mention_context.shared
+          !== mention.mention_context_original.shared
+    ) {
+      corrections.push({
+        id: mention.id,
+        doi: mention.doi,
+        texts: [
+          {
+            text: mention.context,
+            class_attributes: {
+              classification: {
+                used: {
+                  previousValue: mention.mention_context_original.used,
+                  score: 1.0,
+                  value: mention.mention_context.used,
+                },
+                created: {
+                  previousValue: mention.mention_context_original.created,
+                  score: 1.0,
+                  value: mention.mention_context.created,
+                },
+                shared: {
+                  previousValue: mention.mention_context_original.shared,
+                  score: 1.0,
+                  value: mention.mention_context.shared,
+                },
+              },
+            },
+          },
+        ],
+      });
+    }
+    return corrections;
+  })
+  .flat();
 
 export { getAffiliationsCorrections, getMentionsCorrections };
diff --git a/server/src/utils/github.js b/server/src/utils/github.js
@@ -93,11 +93,11 @@ const createIssue = ({ email, issue, type }) => {
     case 'openalex-affiliations':
       return createIssueOpenAlexAffiliations({ email, issue });
     default:
-      console.error(`Error wile creating Github issue as "type" should be one of ["mentions-characterizations", "openalex-affiliations"] instead of "${type}".`);
+      console.error(
+        `Error wile creating Github issue as "type" should be one of ["mentions-characterizations", "openalex-affiliations"] instead of "${type}".`,
+      );
       return false;
   }
 };
 
-export {
-  createIssue,
-};
+export { createIssue };