lez see

dataplat · Oct 25, 2024 · a09937f · a09937f
1 parent b5be793
commit a09937f
Show file tree

Hide file tree

Showing 27 changed files with 85 additions and 29 deletions.
diff --git a/.aider/prompts/conventions.md b/.aider/prompts/conventions.md
@@ -132,7 +132,9 @@ Describe "Get-DbaDatabase" -Tag "UnitTests" {
            $expected += @(
                "SqlInstance",
                "SqlCredential",
-               "Database"
+               "Database",
+               "Confirm",
+               "WhatIf"
            )
        }
 
@@ -169,9 +171,11 @@ Describe "Get-DbaDatabase" -Tag "IntegrationTests" {
 }
 ```
 
-## DO NOT
+## Additional instructions
+
 - DO NOT use `$MyInvocation.MyCommand.Name` to get command names
 - DO NOT use the old `knownParameters` validation approach
 - DO NOT include loose code outside of proper test blocks
 - DO NOT remove comments like "#TestConfig.instance3" or "#$TestConfig.instance2 for appveyor"
-- DO NOT use $_ DO use $PSItem instead
+- DO NOT use $_ DO use $PSItem instead
+- Parameter validation is ALWAYS tagged as a Unit Test
diff --git a/tests/Add-DbaAgDatabase.Tests.ps1 b/tests/Add-DbaAgDatabase.Tests.ps1
@@ -20,7 +20,9 @@ Describe "Add-DbaAgDatabase" -Tag "UnitTests" {
                 "SharedPath",
                 "UseLastBackup",
                 "AdvancedBackupParams",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaAgListener.Tests.ps1 b/tests/Add-DbaAgListener.Tests.ps1
@@ -20,7 +20,9 @@ Describe "Add-DbaAgListener" -Tag "UnitTests" {
                 "Dhcp",
                 "Passthru",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaAgReplica.Tests.ps1 b/tests/Add-DbaAgReplica.Tests.ps1
@@ -28,7 +28,9 @@ Describe "Add-DbaAgReplica" -Tag "UnitTests" {
                 "ConfigureXESession",
                 "SessionTimeout",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaComputerCertificate.Tests.ps1 b/tests/Add-DbaComputerCertificate.Tests.ps1
@@ -17,7 +17,9 @@ Describe "Add-DbaComputerCertificate" -Tag "UnitTests" {
                 "Store",
                 "Folder",
                 "Flag",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaDbMirrorMonitor.Tests.ps1 b/tests/Add-DbaDbMirrorMonitor.Tests.ps1
@@ -11,7 +11,9 @@ Describe "Add-DbaDbMirrorMonitor" -Tag "UnitTests" {
             $expected += @(
                 "SqlInstance",
                 "SqlCredential",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaDbRoleMember.Tests.ps1 b/tests/Add-DbaDbRoleMember.Tests.ps1
@@ -15,7 +15,9 @@ Describe "Add-DbaDbRoleMember" -Tag "UnitTests" {
                 "Role",
                 "Member",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaExtendedProperty.Tests.ps1 b/tests/Add-DbaExtendedProperty.Tests.ps1
@@ -15,7 +15,9 @@ Describe "Add-DbaExtendedProperty" -Tag "UnitTests" {
                 "Name",
                 "Value",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaPfDataCollectorCounter.Tests.ps1 b/tests/Add-DbaPfDataCollectorCounter.Tests.ps1
@@ -15,7 +15,9 @@ Describe "Add-DbaPfDataCollectorCounter" -Tag "UnitTests" {
                 "Collector",
                 "Counter",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaRegServer.Tests.ps1 b/tests/Add-DbaRegServer.Tests.ps1
@@ -21,7 +21,9 @@ Describe "Add-DbaRegServer" -Tag "UnitTests" {
                 "OtherParams",
                 "InputObject",
                 "ServerObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaRegServerGroup.Tests.ps1 b/tests/Add-DbaRegServerGroup.Tests.ps1
@@ -15,7 +15,9 @@ Describe "Add-DbaRegServerGroup" -Tag "UnitTests" {
                 "Description",
                 "Group",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Add-DbaServerRoleMember.Tests.ps1 b/tests/Add-DbaServerRoleMember.Tests.ps1
@@ -15,7 +15,9 @@ Describe "Add-DbaServerRoleMember" -Tag "UnitTests" {
                 "Login",
                 "Role",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Backup-DbaComputerCertificate.Tests.ps1 b/tests/Backup-DbaComputerCertificate.Tests.ps1
@@ -14,7 +14,9 @@ Describe "Backup-DbaComputerCertificate" -Tag "UnitTests" {
                 "Path",
                 "FilePath",
                 "Type",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Backup-DbaDbCertificate.Tests.ps1 b/tests/Backup-DbaDbCertificate.Tests.ps1
@@ -19,7 +19,9 @@ Describe "Backup-DbaDbCertificate" -Tag "UnitTests" {
                 "Path",
                 "Suffix",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Backup-DbaServiceMasterKey.Tests.ps1 b/tests/Backup-DbaServiceMasterKey.Tests.ps1
@@ -14,7 +14,9 @@ Describe "Backup-DbaServiceMasterKey" -Tag "UnitTests" {
                 "KeyCredential",
                 "SecurePassword",
                 "Path",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Clear-DbaConnectionPool.Tests.ps1 b/tests/Clear-DbaConnectionPool.Tests.ps1
@@ -11,7 +11,9 @@ Describe "Clear-DbaConnectionPool" -Tag "UnitTests" {
             $expected += @(
                 "ComputerName",
                 "Credential",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Clear-DbaLatchStatistics.Tests.ps1 b/tests/Clear-DbaLatchStatistics.Tests.ps1
@@ -11,7 +11,9 @@ Describe "Clear-DbaLatchStatistics" -Tag "UnitTests" {
             $expected += @(
                 "SqlInstance",
                 "SqlCredential",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Clear-DbaPlanCache.Tests.ps1 b/tests/Clear-DbaPlanCache.Tests.ps1
@@ -13,7 +13,9 @@ Describe "Clear-DbaPlanCache" -Tag "UnitTests" {
                 "SqlCredential",
                 "Threshold",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Clear-DbaWaitStatistics.Tests.ps1 b/tests/Clear-DbaWaitStatistics.Tests.ps1
@@ -11,7 +11,9 @@ Describe "Clear-DbaWaitStatistics" -Tag "UnitTests" {
             $expected += @(
                 "SqlInstance",
                 "SqlCredential",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Convert-DbaLsn.Tests.ps1 b/tests/Convert-DbaLsn.Tests.ps1
@@ -10,7 +10,9 @@ Describe "Convert-DbaLSN" -Tag "UnitTests" {
 
             $expected += @(
                 "LSN",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Convert-DbaMaskingValue.Tests.ps1 b/tests/Convert-DbaMaskingValue.Tests.ps1
@@ -12,7 +12,9 @@ Describe "Convert-DbaMaskingValue" -Tag "UnitTests" {
                 "Value",
                 "DataType",
                 "Nullable",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/ConvertTo-DbaTimeline.Tests.ps1 b/tests/ConvertTo-DbaTimeline.Tests.ps1
@@ -11,7 +11,9 @@ Describe "ConvertTo-DbaTimeline" -Tag "UnitTests" {
             $expected += @(
                 "InputObject",
                 "ExcludeRowLabel",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/ConvertTo-DbaXESession.Tests.ps1 b/tests/ConvertTo-DbaXESession.Tests.ps1
@@ -12,7 +12,9 @@ Describe "ConvertTo-DbaXESession" -Tag "UnitTests" {
                 "InputObject",
                 "Name",
                 "OutputScriptOnly",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Copy-DbaAgentAlert.Tests.ps1 b/tests/Copy-DbaAgentAlert.Tests.ps1
@@ -17,7 +17,9 @@ Describe "Copy-DbaAgentAlert" -Tag "UnitTests" {
                 "ExcludeAlert",
                 "IncludeDefaults",
                 "Force",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Copy-DbaAgentJob.Tests.ps1 b/tests/Copy-DbaAgentJob.Tests.ps1
@@ -30,7 +30,9 @@ Describe "Copy-DbaAgentJob" -Tag "IntegrationTests" {
                 "DisableOnDestination",
                 "Force",
                 "InputObject",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Copy-DbaAgentJobCategory.Tests.ps1 b/tests/Copy-DbaAgentJobCategory.Tests.ps1
@@ -25,7 +25,9 @@ Describe "Copy-DbaAgentJobCategory" -Tag "IntegrationTests" {
                 "AgentCategory",
                 "OperatorCategory",
                 "Force",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }
 

diff --git a/tests/Copy-DbaAgentOperator.Tests.ps1 b/tests/Copy-DbaAgentOperator.Tests.ps1
@@ -16,7 +16,9 @@ Describe "Copy-DbaAgentOperator" -Tag "UnitTests" {
                 "Operator",
                 "ExcludeOperator",
                 "Force",
-                "EnableException"
+                "EnableException",
+                "Confirm",
+                "WhatIf"
             )
         }