Remove-DbaDatabaseSafely - Fix Exception handling #9115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did review all the code. I believe you found all the places for Speaking of that, is dbatools designed to inherit for this parameter? |
|
@mattcargile because it's built into the library and actively part of the library, it does inherit the value. if it was an external command, it would not :O |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Remove-DbaDatabaseSafely-catchBlock Doesn't Trigger On Failed Backup #9111 ).\tests\manual.pester.ps1)I hope I have found all missing "EnableException". From all the bugs we have found so far in this command - I would not recommend using it in production...
Has someone time to have a deeper look at this command? I personally don't have time for that.