Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change splatting to remove <br> from docs #9292

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jpomfret
Copy link
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

The docs on the website have <br> at the end of each row currently from splatting
image

@niphlod - is there any other options? or is this the fix? Got this from looking at other commands where it works
image

If this is the fix - I have some more to fix before this PR gets merged... so marking as draft for now

@jpomfret jpomfret marked this pull request as draft March 26, 2024 17:16
@niphlod
Copy link
Contributor

niphlod commented Mar 26, 2024

hi @jpomfret , there's a whole logic behind doc generation but can be replicated locally. If you give me a specific page we can see if it's a problem on the "generation" or on the "display" side of things

edit: that being said you got the gist. Right now multiline examples should be prefixed by either PS C:\> or >> . We could change it but it needs proper testing to avoid breaking other pages.

For the curious enough, logic is in here https://github.com/dataplat/docs/blob/master/assets/templates/to_md.ps1, it turns the json help into markdown pages.

@jpomfret
Copy link
Collaborator Author

jpomfret commented Mar 26, 2024

This is an example: https://docs.dbatools.io/New-DbaReplCreationScriptOptions.

I will check out that logic and test locally, and then upload the rest of the changes here. Thanks!

@jpomfret jpomfret marked this pull request as ready for review March 27, 2024 12:24
@potatoqualitee potatoqualitee merged commit 5ddae43 into dataplat:development Mar 27, 2024
3 checks passed
@potatoqualitee
Copy link
Member

MERCi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants