-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for Get-DbaEstimatedCompletionTime #9522
Fix test for Get-DbaEstimatedCompletionTime #9522
Conversation
I think we should skip this test on AppVeyor and only test this command from time to time on a local instance with a big database. What do you think? |
Yes, we can skip 👍🏼 |
New idea for those tests: We could use a freely availably database backup for the tests. I refactored the test to use the Stackoverflow database: I also changed the BeforeAll to test new variables But currently this backup is made with a SQL Server 2022, so it can not be used with the current instance in AppVeyor. So we should disable the test on AppVeyor. Here is a screenshot from the AppVeyor log with the current code: |
@potatoqualitee : If I change |
Happy to! btw dont worry about my aider branches, I am still working on my prompts and will start with a fresh branch once it's all done and if it takes a bit long, ill copy and rewriite your changes. |
lgtm! |
But the test will not work because the databae is too small and CHECKDB is to fast...