Updates supporting receipts with MMRIVER draft inclusion proofs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
register_signed_statement updated to support attachment of MMRIVER COSE Receipts of inclusion. Updated the implementation to fetch the public event, compute the leaf and then *verify* the returned receipt before attaching it to the statement.
robinbryce
commented
Oct 29, 2024
fix: use url rather than fqdn fix: add input for url
SteveLasker
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Perfect to have the new verification code and the ability to test on our soak infra, however we can't merge this until it's rolled into production.
We should also likely converge with the new ScraPy work Jon is doing.
Tagging with "Request Changes" to avoid accidental merger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
register_signed_statement updated to support attachment of MMRIVER COSE Receipts of inclusion.
Updated the implementation to fetch the public event, compute the leaf and then verify the returned receipt before attaching it to the statement.
I was mostly in "get it working mode" so there is some clean up. Also, I'm not sure the minor bits of refactoring I did are aligned with the vision for the repo. Will happily undo that if its not whats wanted