Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Facebook support? #225

Closed
SachaG opened this issue Oct 30, 2015 · 4 comments
Closed

Add Facebook support? #225

SachaG opened this issue Oct 30, 2015 · 4 comments
Labels
Enhancement

Comments

@SachaG
Copy link

SachaG commented Oct 30, 2015

I feel like Facebook videos are pretty common these days, maybe it could be one of the default supported players?
@davatron5000
Copy link
Owner

@SachaG This is probably a good idea. Do you know any hosted/embedded statistics for FB videos? It seems like there's A LOT of videos, but (anecdotally) are only rarely embedded outside the FB ecosystem.

@SachaG
Copy link
Author

SachaG commented Jan 19, 2016

I'm not sure, but I'm seeing them more and more embedded on Reddit and would like to support them in Telescope, too.

@SachaG
Copy link
Author

SachaG commented Jan 19, 2016

I can probably submit a PR if you think it makes sense to add it.

@davatron5000 davatron5000 mentioned this issue Apr 21, 2016
Open
@davatron5000
Copy link
Owner

Merging with #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davatron5000 @SachaG