Facebook have updated their embed code

[robertsimpson]

Hi Dave,

I'm not sure if you're aware, but Facebook have recently updated their video embed code and are now using an iframe instead of JS.

As you can probably guess by this post being here things aren't behaving as expected.

You can see what I mean here: http://bit.ly/20Ymsb3

Facebook have really made a mess of this as their code throws a lot of console errors.

Any ideas?

Cheers,
Robert

[robertsimpson]

I've had to change the embedded video to YouTube for the moment, just in case you check that link and wonder what I've been smoking!

[davatron5000]

@robertsimpson Can you make a CodePen of the issue since your page has changed? Without any code samples I'll have to close the issue.

We don't officially support the FB video embed, although that's been proposed in #225.

[robertsimpson]

@davatron5000 Sorry Dave, I was away for a few days. Here's a CodePen link: https://codepen.io/robertsimpson/pen/XdxMLY

[robertsimpson]

@davatron5000 Hi Dave, did you manage to take a copy of the example code I posted?

[davatron5000]

https://codepen.io/davatron5000/pen/bZWrbr?editors=0010

Sorry I had to fork your pen. Normally when we ask for a "reduced test case" we're looking for the minimal amount of code to isolate the problem.

I got Fitvids+Facebook working using the customSelector option. I may have overly reduced this test case. Take a look and see if this looks about right.

[robertsimpson]

Hi Dave, does the customSelector flag limit what fitVids() targets? If not, that looks good!

[davatron5000]

@robertsimpson customSelector adds to the things that FitVids targets. The ignore option will ignore selectors you choose.