Added tests to cover missing dc:format cases

davidjgonzalez · Jul 22, 2024 · 64747ab · 64747ab
1 parent eb9854c
commit 64747ab
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 0 deletions.
diff --git a/...etshare/content/renditions/impl/dispatchers/AssetDeliveryRenditionDispatcherImplTest.java b/...etshare/content/renditions/impl/dispatchers/AssetDeliveryRenditionDispatcherImplTest.java
@@ -86,4 +86,26 @@ public void testAccepts_False() throws Exception {
 
         assertFalse("OFT should not be accepted", dispatcher.accepts(assetModel, "test"));
     }
+
+
+    @Test
+    public void testAccepts_NoDcFormat_False() {
+        ctx.currentResource("/content/dam/test.no-dc-format");
+        AssetModel assetModel = ctx.request().adaptTo(AssetModel.class);
+
+        AssetRenditionDispatcher dispatcher = ctx.getService(AssetRenditionDispatcher.class);
+
+        assertFalse("Missing dc:format should not be accepted", dispatcher.accepts(assetModel, "test"));
+    }
+
+
+    @Test
+    public void testAccepts_BlankDcFormat_False() {
+        ctx.currentResource("/content/dam/test.blank-dc-format");
+        AssetModel assetModel = ctx.request().adaptTo(AssetModel.class);
+
+        AssetRenditionDispatcher dispatcher = ctx.getService(AssetRenditionDispatcher.class);
+
+        assertFalse("Blank dc:format should not be accepted", dispatcher.accepts(assetModel, "test"));
+    }
 }
diff --git a/...etshare/content/renditions/impl/dispatchers/AssetDeliveryRenditionDispatcherImplTest.json b/...etshare/content/renditions/impl/dispatchers/AssetDeliveryRenditionDispatcherImplTest.json
@@ -39,6 +39,45 @@
           }
         }
       }
+    },
+    "test.no-dc-format": {
+      "jcr:primaryType": "dam:Asset",
+      "jcr:content": {
+        "jcr:primaryType": "nt:unstructured",
+        "metadata": {
+          "jcr:primaryType": "nt:unstructured"
+        },
+        "renditions": {
+          "jcr:primaryType": "nt:unstructured",
+          "cq5dam.web.1280.1280.png": {
+            "jcr:primaryType": "nt:file",
+            "jcr:content": {
+              "jcr:primaryType": "oak:Resource",
+              "jcr:mimeType": "image/png"
+            }
+          }
+        }
+      }
+    },
+    "test.blank-dc-format": {
+      "jcr:primaryType": "dam:Asset",
+      "jcr:content": {
+        "jcr:primaryType": "nt:unstructured",
+        "metadata": {
+          "jcr:primaryType": "nt:unstructured",
+            "dc:format": " "
+        },
+        "renditions": {
+          "jcr:primaryType": "nt:unstructured",
+          "cq5dam.web.1280.1280.png": {
+            "jcr:primaryType": "nt:file",
+            "jcr:content": {
+              "jcr:primaryType": "oak:Resource",
+              "jcr:mimeType": "image/png"
+            }
+          }
+        }
+      }
     }
   }
 }