Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 18 commits into from
Sep 20, 2023
Merged

Initial implementation #1

merged 18 commits into from
Sep 20, 2023

Conversation

davilima6
Copy link
Owner

@davilima6 davilima6 commented Dec 26, 2022

Todo

Considerations for improvements

  • add class names to avoid styling bare elements
  • replace all direct color usages by design tokens/css variables
  • preload batch of questions to avoid displaying "Loading" message after initial page load
  • add generator-based find helper to search over map values without allocating an array (similar to this filter helper)
  • bump requirements to Node 17 and replace JSON.parse(JSON.stringify(x)) by structuredClone(x)
  • add animations for correct/wrong answers and on game over
  • setup CI and PR preview deployments, e.g. integrate with CircleCI/Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant