-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon/manifest #193
base: master
Are you sure you want to change the base?
Add favicon/manifest #193
Conversation
@missmatsuko The build for your first push was 6 mins and the second push took 10 mins to deploy. |
I was looking at the build scripts and I think build is going to delete all the files in public regardless if they were committed or not? This might be why committing the generated files aren't having an affect on build time.
|
I took a look at the |
@missmatsuko First of all, thank for taking the time to figure out this issue. We appreciate each PR, I think our problem in the starter is that we should fix the caching in the build process, and an ideal tool would be to use |
Generates favicon/web app icon from single source SVG and adds web app manifest.
Closes #191
What kind of change does this PR introduce?
Feature
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?