Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the chirp profile color for linked LAOs members #1963

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Changing the chirp profile color for linked LAOs members #1963

merged 3 commits into from
Jun 29, 2024

Conversation

quadcopterman
Copy link
Contributor

When two (or more) LAOs are linked with federation and they send chirps, chirps from the user's LAO are displayed with a blue profile and chirps from another LAO are displayed with gray profile.

Screenshot_20240627_235401

@quadcopterman quadcopterman requested a review from Kaz-ookid June 28, 2024 13:01
@quadcopterman quadcopterman self-assigned this Jun 28, 2024
@quadcopterman quadcopterman requested a review from a team as a code owner June 28, 2024 13:01
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 25
▀▀▀▀		 1d 19h 11m
 12
▀▀
matteosz
🥈		 8
▀		 3d 16h 5m
▀		 21
▀▀▀
arnauds5
🥉		 7
▀		 4h 29m
 4
▀
emonnin-epfl
 6
▀		 8h 20m
 8
▀
sgueissa
 4
▀		 1h 25m
 7
▀
quadcopterman
 3
 10d 7h 3m
▀▀▀		 1
1florentin
 2
 10d 5h 50m
▀▀▀		 0
MariemBaccari
 2
 22h 39m
 6
▀
simone-kalbermatter
 2
 5h 32m
 0
onsriahi14
 2
 6d 4h 27m
▀▀		 4
▀
Kaz-ookid
 2
 2d 4h 12m
▀		 9
▀
⚡️ Pull request stats

matteosz
matteosz reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just 1 comment

...c/test/ui/robolectric/com/github/dedis/popstellar/ui/lao/socialmedia/ChirpListAdapterTest.kt Outdated
// The chirp of the other LAO should be gray
val profile2 = view2.findViewById<ImageView>(R.id.social_media_profile)
Assert.assertNotNull(profile2)
Assert.assertEquals(-8355712, profile2.imageTintList?.defaultColor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use the android color resource here instead of hardcoding the value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will be cleaner

@quadcopterman quadcopterman requested a review from matteosz June 28, 2024 14:20
@Kaz-ookid
Copy link
Contributor

Kaz-ookid commented Jun 28, 2024 •
edited
Loading

Just a quick question : can more than 2 LAO be linked? if yes, what is the color rule? Any LAO not being ours would appear grey, or should all LAO be differentiable?

@quadcopterman
Copy link
Contributor Author

Yes more than two LAOs can be linked. For now blue represents our LAO and grey represents any other LAO

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

matteosz
matteosz approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matteosz matteosz changed the title Changing the chrip profile color for linked LAOs members Changing the chirp profile color for linked LAOs members Jun 28, 2024
@quadcopterman quadcopterman added this pull request to the merge queue Jun 29, 2024
Merged via the queue into master with commit aad7171 Jun 29, 2024
17 checks passed
@quadcopterman quadcopterman deleted the work-fe2-johan-profile-federation branch June 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteosz matteosz matteosz approved these changes

@Kaz-ookid Kaz-ookid Awaiting requested review from Kaz-ookid

Assignees

@quadcopterman quadcopterman

Labels
fe2-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quadcopterman @Kaz-ookid @matteosz