Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Chroma - pin tokenizers #1223

Merged
merged 4 commits into from
Nov 28, 2024
Merged

chore: Chroma - pin tokenizers #1223

merged 4 commits into from
Nov 28, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 28, 2024

Related Issues

Proposed Changes:

How did you test it?

CI

Notes for the reviewer

  • the pin will be removed as soon as Chroma releases a new version where they adopt the pin themselves
  • (in general, we should think about when to discontinue python 3.8 compatibility)

Checklist

@anakin87 anakin87 changed the title try adding tokenizers to dependencies chore: Chroma - pin tokenizers Nov 28, 2024
@anakin87 anakin87 marked this pull request as ready for review November 28, 2024 08:52
@anakin87 anakin87 requested a review from a team as a code owner November 28, 2024 08:52
@anakin87 anakin87 requested review from shadeMe and removed request for a team November 28, 2024 08:52
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we open a tracking issue for reverting this change?

@anakin87
Copy link
Member Author

I created the issue to revert this change: #1225.

@anakin87 anakin87 merged commit 5751605 into main Nov 28, 2024
13 checks passed
@anakin87 anakin87 deleted the chroma-tokenizers branch November 28, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants