-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing due to new sentence behaviour #372
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
either we use main or this will fail until we make a new release |
Ah, I understand. Let's leave this PR open until 2.9.0. Can you also fix tutorial 42? |
this is the 42 |
sorry I was meaning 39 |
It seems that we also need to also install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the NLTK dependency.
Let's merge after Haystack 2.9.0 release.
merge when 2.9.0 is released