Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing due to new sentence behaviour #372

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Dec 13, 2024

merge when 2.9.0 is released

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@davidsbatista
Copy link
Contributor Author

either we use main or this will fail until we make a new release

@anakin87
Copy link
Member

Ah, I understand. Let's leave this PR open until 2.9.0.

Can you also fix tutorial 42?

@davidsbatista
Copy link
Contributor Author

this is the 42

@anakin87
Copy link
Member

sorry I was meaning 39

@anakin87
Copy link
Member

It seems that we also need to also install nltk in this notebook

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the NLTK dependency.

Let's merge after Haystack 2.9.0 release.

@anakin87 anakin87 merged commit bed7bfc into main Jan 15, 2025
4 checks passed
@anakin87 anakin87 deleted the fixing-new-sentence-behaviour branch January 15, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants