Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tutorial 35 #378

Merged
merged 4 commits into from
Jan 22, 2025
Merged

fix tutorial 35 #378

merged 4 commits into from
Jan 22, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 22, 2025

Nightly tests are failing: https://github.com/deepset-ai/haystack-tutorials/actions/runs/12898222445/job/35964884824

I'm reorganizing the dependencies:

  • remove dependencies (especially the pin on pydantic) which I think are no longer needed after the removal of external evaluation-related integrations from this tutorial.
  • add sentence-transformers

I'm not modifying the notebook, so complete tests don't run. I've temporarily triggered them: you can inspect the positive results at https://github.com/deepset-ai/haystack-tutorials/actions/runs/12904846558/job/35982849507.

@anakin87 anakin87 marked this pull request as ready for review January 22, 2025 09:07
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anakin87 anakin87 requested a review from bilgeyucel January 22, 2025 09:24
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@bilgeyucel bilgeyucel merged commit e447ea9 into main Jan 22, 2025
1 check passed
@bilgeyucel bilgeyucel deleted the fix-35 branch January 22, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants