Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix, bf16 optimizer remove dup loop #7054

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fix, bf16 optimizer remove dup loop #7054

merged 2 commits into from
Feb 20, 2025

Conversation

wukong1992
Copy link
Contributor

bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range

@tjruwase
Copy link
Contributor

@wukong1992, thanks for the bug fix. Please address the Formatting and DCO check failures

  1. Formatting: https://github.com/deepspeedai/DeepSpeed/blob/master/CONTRIBUTING.md#prerequisites
  2. DCO: https://github.com/deepspeedai/DeepSpeed/pull/7054/checks?check_run_id=37490138421

@wukong1992 wukong1992 force-pushed the fix-bf16-moe-refresh-params branch from c0f04e2 to ec29a11 Compare February 20, 2025 03:09
@wukong1992 wukong1992 force-pushed the fix-bf16-moe-refresh-params branch from ec29a11 to af19de2 Compare February 20, 2025 03:14
@tjruwase tjruwase added this pull request to the merge queue Feb 20, 2025
Merged via the queue into deepspeedai:master with commit e2dc3ee Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@tohtana tohtana Awaiting requested review from tohtana tohtana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wukong1992 @tjruwase @hwchen2017