Avoid graph breaks in torch.compile caused by inner classes in the backward hooks #7062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is part of the effort to improve Deepspeed performance when using PyTorch compile. There is a known bug in torch.compile (pytorch/pytorch#128942) which causes a graph break when a inner class is defined within a method that is being compiled and logs the following message: [__graph_breaks] torch._dynamo.exc.Unsupported: missing: LOAD_BUILD_CLASS This is the case with the inner classes PreBackwardFunctionForModule and PostBackwardFunctionModule. While there is an open PR for this (pytorch/pytorch#133805), we can solve the issue by moving the inner classes into the initialization code. No graph breaks and the corresponding logs are produced anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to improve Deepspeed performance when using PyTorch compile.
There is a known bug in torch.compile which causes a graph break when an inner class is defined within
a method that is being compiled. The following would then appear in the log:
[__graph_breaks] torch._dynamo.exc.Unsupported: missing: LOAD_BUILD_CLASSThis is the case with the inner classes
PreBackwardFunctionForModuleandPostBackwardFunctionModule.While there is an open PyTorch PR#133805 for this, we can solve the issue by moving the inner classes into the initialization code.
No graph breaks and the corresponding logs are produced anymore.